80026[TASK] Remove TYPO3-related items from localStorage when resetting config
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 78
-
Andreas Kienast uploaded patch set 1 07/14/23, 13:15
-
core-ci voted on patch set 1 V +1 07/14/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44138
-
Oliver Klee voted on patch set 1 CR +1 07/14/23, 13:51
-
Stefan Bürk voted on patch set 1 V +1 CR +1 07/14/23, 17:11
-
Benjamin Franzke commented on patch set 1 CR -1 07/17/23, 07:06
-
Andreas Kienast commented on patch set 1 07/17/23, 07:33
setup-module.ts:54Reply`Client.unsetByPrefix()` internally uses `t3-` already as a hard-coded prefix. OTOH, there is `Client.clear()` that indeed flushes the full local storage. -
Benjamin Franzke commented on patch set 1 V +2 CR +2 07/17/23, 08:36
setup-module.ts:54ReplyAlight, got confused by installtool setting values via `localStorage.setItem('typo3-install-modulesCollapsed', 'false');` -
Benjamin Franzke merged patch set 2 07/17/23, 08:37
setup-module.ts:54