Review main Merged

80027[BUGFIX] Do not consider done `UpgradeWizard` as not found

Stefan Bürk CR +2 V +2 Easy +4 −1 updated 07/15/23, 20:22

Commit message

Existing upgrade wizards marked as done should not be considered as
not existing and therefore not returning a error exit code in the
cli command. This was the case before TYPO3 v12.2, changing that
behavior with #99586 to support register upgrade wizard based on
a PHP attribute.

Postulating that this was a unintended side-effect for single upgrade
execution, this change adds a early check if the upgrade wizards is
marked as done to keep a non-error exit code and outputting a use-full
note to the console.

Note: Executing all possible upgrade-wizards are not related to this
      issue, and therefore do not need any adjustment. But this is
      the reason for keeping the `isWizardDone()` check in method
      `getWizard()`.

This can be tested with:

> bin/typo3 upgrade:run migrateSiteSettings ; echo "$?"

for TYPO3 main or

> bin/typo3 upgrade:run svgFilesSanitization ; echo "$?"

for TYPO3 12.4.x (and 11.5.x as verification)

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 07/14/23, 16:38

  2. core-ci voted on patch set 1 V +1 07/14/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44139

  3. Oliver Klee updated the commit message in patch set 2 V +1 07/14/23, 17:04

  4. Oliver Klee voted on patch set 2 CR +1 07/14/23, 17:05

  5. core-ci voted on patch set 2 V +1 07/14/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44142

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 07/14/23, 20:52

  7. Nikita Hovratov voted on patch set 2 V +2 CR +2 07/15/23, 20:21

  8. Nikita Hovratov merged patch set 3 07/15/23, 20:22