Review main Merged

80031[TASK] Only pass strings to PHP string functions in EXT:backend

Oliver Klee CR +2 V +2 Easy +3 −3 updated 07/17/23, 15:53

Commit message

This avoids type errors when strict typing is set for internal
classes in EXT:backend (when we cannot rely on PHP's implicit
typcasting anymore).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 69

  1. Oliver Klee uploaded patch set 1 07/14/23, 20:12

  2. core-ci voted on patch set 1 V +1 07/14/23, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44150

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/17/23, 11:40

  4. Christian Kuhn rebased onto patch set 3 07/17/23, 11:40

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 07/17/23, 11:40

  6. core-ci voted on patch set 2 V +1 07/17/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44212

  7. core-ci voted on patch set 3 V +1 07/17/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44213

  8. Stefan Bürk voted on patch set 3 V +2 CR +2 07/17/23, 15:53

  9. Stefan Bürk merged patch set 4 07/17/23, 15:53