Review 11.5 Merged

80032[BUGFIX] Avoid exception in presets of Install Tool

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 07/14/23, 22:27

Commit message

The method str_contains requires the 1st argument to be a string.
So we need to ensure that it is a string.

(It can be `null` if the command ran into an error.)

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 47

  1. Oli Bartsch uploaded patch set 1 07/14/23, 20:34

  2. core-ci voted on patch set 1 V -1 07/14/23, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44152

  3. core-ci commented on patch set 1 07/14/23, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44152

  4. core-ci voted on patch set 1 V +1 07/14/23, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44152

  5. Oliver Klee voted on patch set 1 CR +1 07/14/23, 21:52

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 07/14/23, 22:27

  7. Oli Bartsch merged patch set 2 07/14/23, 22:27