Review main Merged

80034[BUGFIX] Allow attributes for anchors in ckeditor

Sybille Peters CR +2 V +2 Easy +4 −5 updated 07/24/23, 15:51

Commit message

Ckeditor 5 is used since TYPO3 12 which has significantly changed
how elements in the DOM are handled.

The `a` element is handled in the plugin typo3-link, but it did not
handle some attributes correctly, specifically:

- class
- rel
- target

This resulted in only `href` and `title` being persisted when saving
or switching between source and normal mode.

This is now fixed, so that all 5 attributes will be handled
correctly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Kevin Appelt +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1825

  1. Sybille Peters uploaded patch set 1 07/15/23, 07:20

  2. core-ci voted on patch set 1 V +1 07/15/23, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44159

  3. Sybille Peters updated the commit message in patch set 2 V +1 07/16/23, 06:47

  4. core-ci voted on patch set 2 V +1 07/16/23, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44187

  5. Oliver Klee updated the commit message in patch set 3 V +1 07/16/23, 08:11

  6. core-ci voted on patch set 3 V +1 07/16/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44190

  7. Sybille Peters updated the commit message in patch set 4 V +1 07/18/23, 17:10

  8. core-ci voted on patch set 4 V +1 07/18/23, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44275

  9. Sybille Peters updated the commit message in patch set 5 V +1 07/18/23, 17:55

  10. core-ci voted on patch set 5 V +1 07/18/23, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44276

  11. Sybille Peters updated the commit message in patch set 6 V +1 07/18/23, 18:25

  12. core-ci voted on patch set 6 V +1 07/18/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44277

  13. Sybille Peters commented on patch set 6 V -1 07/18/23, 18:59

    Unfortunately, I can still find some cases where the attributes are not persisted. Needs further investigation ...
  14. Sybille Peters voted on patch set 6 V 0 07/23/23, 05:48

  15. Sybille Peters updated the commit message in patch set 7 V +1 07/23/23, 10:59

  16. core-ci voted on patch set 7 V +1 07/23/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44435

  17. Andreas Kienast voted on patch set 7 CR +1 07/24/23, 11:26

  18. Mathias Brodala voted on patch set 7 CR +1 07/24/23, 11:27

  19. Benjamin Franzke voted on patch set 7 CR +1 07/24/23, 11:32

  20. Kevin Appelt voted on patch set 7 CR +1 07/24/23, 12:19

  21. Oliver Hader voted on patch set 7 CR +1 07/24/23, 12:39

  22. Oliver Hader voted on patch set 7 V +1 07/24/23, 12:47

  23. Oli Bartsch voted on patch set 7 V +1 CR +1 07/24/23, 14:17

  24. Benjamin Franzke voted on patch set 7 V +2 CR +2 07/24/23, 15:51

  25. Benjamin Franzke merged patch set 8 07/24/23, 15:51