Review main Merged

80038[TASK] Add some missing string casts in EXT:core

Oliver Klee CR +2 V +2 Easy +3 −3 updated 07/17/23, 15:52

Commit message

Add string casts in functional calls where the parameter
needs to be a string, but currently is not ensured to be.

This avoids type errors when the internal classes in EXT:core
are made strict.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Oliver Klee uploaded patch set 1 07/15/23, 10:49

  2. core-ci voted on patch set 1 V +1 07/15/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44168

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/17/23, 11:37

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 07/17/23, 11:38

  5. Christian Kuhn rebased onto patch set 3 CR +1 V +1 07/17/23, 11:38

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 07/17/23, 11:38

  7. core-ci voted on patch set 3 V +1 07/17/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44211

  8. core-ci voted on patch set 2 V +1 07/17/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44210

  9. Stefan Bürk voted on patch set 3 V +2 CR +2 07/17/23, 15:52

  10. Stefan Bürk merged patch set 4 07/17/23, 15:52