Review 12.4 Merged

80044[TASK] Ensure TypoScript traversers are stateless

Christian Kuhn CR +2 V +2 Hard +269 −213 updated 07/17/23, 11:04

Commit message

The TypoScript traverser service classes should be
stateless: They currently have a visitor property
plus addVisitor() and resetVisitors() methods.

The patch refacorts the traversers by handing the
list of visitors directly to traverse() and avoids
service class state this way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 20

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/17/23, 10:56

  2. core-ci voted on patch set 1 V +1 07/17/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44208

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/17/23, 11:04

  4. Christian Kuhn merged patch set 2 07/17/23, 11:04