Review main Merged

80049[TASK] Use Backend/Attribute/Controller attribute more consistently

Christian Kuhn CR +2 V +2 Normal +71 −106 updated 07/18/23, 08:04

Commit message

The PHP attribute #[Controller] has been introduced with
issue #99055 to declare backend module controllers public
and non-shared, by auto-configuring affected controllers.

The patch changes various existing controllers to use
the attribute instead of dedicated 'backend.controller'
tags in Services.yaml. This simplifies the setup, avoids
left over entries in Services.yaml and makes them a bit
smaller.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 48

Show 28 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 07/17/23, 20:57

  2. Christian Kuhn updated the commit message in patch set 2 07/17/23, 20:58

  3. core-ci voted on patch set 2 V +1 07/17/23, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44224

  4. core-ci voted on patch set 1 V +1 07/17/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44223

  5. Oliver Klee voted on patch set 2 V +1 07/18/23, 07:39

  6. Oliver Klee voted on patch set 2 CR +1 07/18/23, 07:41

  7. Stefan Bürk commented on patch set 2 CR -1 07/18/23, 07:59

    reviewing ...
  8. Stefan Bürk voted on patch set 2 V +2 CR +2 07/18/23, 08:04

  9. Stefan Bürk merged patch set 3 07/18/23, 08:04