Review 11.5 Merged

80068[BUGFIX] Ensure `uid` is not updated when updating resources

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 07/21/23, 20:49

Commit message

When updating entries, the `updateFields` will provide `uid`, which
works fine in MySQL but might lead to problems when working with
stricter DBMS.

Such an example of a DBMS not liking the update of an identity field,
is SQL Server.

Now, I know that SQL Server will not be supported in TYPO3 v12 going
onward, but on the off-chance that somebody has another DBMS than MySQL
or has DBMS that will break when trying to update an identify field,
this bugfix might still be valuable.

The bug exists back to TYPO3 10 at least.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 07/21/23, 20:36

    Cherry Picked from branch 12.4.
  2. core-ci voted on patch set 1 V +1 07/21/23, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44398

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/21/23, 20:48

  4. Stefan Bürk merged patch set 2 07/21/23, 20:49