80072[TASK] Remove `es-module-shims` polyfill
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/core/java-script-item-handler.ts+1 −3
- Build/Sources/TypeScript/core/java-script-item-processor.ts+1 −19
- Build/Sources/TypeScript/install/init-install.ts+1 −1
- Build/Sources/TypeScript/install/init-installer.ts+1 −1
- Build/Gruntfile.js+0 −2
- Build/package-lock.json+0 −6
- Build/package.json+0 −1
- typo3/sysext/backend/Configuration/ContentSecurityPolicies.php1+2 −2
- typo3/sysext/core/Classes/Page/ImportMap.php+1 −15
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/es-module-shims.jsdeleted+0 −1
- typo3/sysext/core/Resources/Public/JavaScript/java-script-item-handler.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/java-script-item-processor.js+1 −1
- typo3/sysext/install/Classes/Controller/ControllerTrait.php+1 −3
- typo3/sysext/install/Resources/Public/JavaScript/init-install.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/init-installer.js+1 −1
Review log 1114
-
Andreas Kienast uploaded patch set 1 07/18/23, 06:14
-
Benjamin Franzke commented on patch set 1 07/18/23, 06:20
Cool! :) Though, I had some issues with Firefox using module script tags recently when working on https://review.typo3.org/c/Packages/TYPO3.CMS/+/79912 Got errrors like: The specifier "@typo3/backend/broadcast-message.js" was a bare specifier, but was not remapped to anything. …but everything worked nonetheless (actually with and without the shim) So yea, I agree that we can remove the shim, but I need to check some details first. -
core-ci voted on patch set 1 V +1 07/18/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44231
-
Andreas Kienast commented on patch set 1 07/18/23, 06:27
Reply
Do you by chance have an unclean state due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/80050? -
Benjamin Franzke commented on patch set 1 07/18/23, 06:50
Reply
no, nothing directly related to these patches, had the mentioned errors a week ago while working on the mentioned patch (copied them from that commit message). (This patch is likely fine, it's just a feeling like: "there is still something wrong with firefox and import maps, but that's most likely only related to script type="module" tags, not import expressions (which we currently only use)) -
Benjamin Franzke uploaded patch set 2
V +107/18/23, 08:53 -
core-ci voted on patch set 2 V +1 07/18/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44237
-
Benjamin Franzke commented on patch set 2 07/18/23, 09:14
ContentSecurityPolicies.php:35Note that the comment was wrong as far as I know (I've added it back then, but it seems I've mixed it up with script-src. frame-src is/was actually needed for the list frame, so I've updated the comment and adapted the directive to only allow self, not all blob urls) -
Christian Kuhn voted on patch set 2 V +1 CR +1 07/18/23, 09:48
-
Benjamin Franzke uploaded patch set 3
CR +1V +107/18/23, 10:17Resolve Merge Conflict -
Christian Kuhn voted on patch set 3 V +1 CR +1 07/18/23, 10:24
-
core-ci voted on patch set 3 V +1 07/18/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44239
-
Andreas Kienast voted on patch set 3 V +2 CR +2 07/18/23, 10:31
-
Andreas Kienast merged patch set 4 07/18/23, 10:31