Review main Merged

80072[TASK] Remove `es-module-shims` polyfill

Andreas Kienast CR +2 V +2 Normal +12 −58 updated 07/18/23, 10:31

Commit message

The polyfill package `es-module-shims` was required for loading
ECMAScript modules that implement import maps. To this day,
all browsers supported by TYPO3 implemented all ESM loading
mechanisms.
While upstream Firefox was fine for quite a while, Firefox ESR had
issues, since it based on Firefox 102 until July 3, 2023, which
requires this polyfill. Since July 4, 2023, Firefox ESR bases on Firefox
115, making this polyfill fully obsolete, which is therefore now removed
along with all fallbacks in the loading process.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1114

  1. Andreas Kienast uploaded patch set 1 07/18/23, 06:14

  2. Benjamin Franzke commented on patch set 1 07/18/23, 06:20

    Cool! :) Though, I had some issues with Firefox using module script tags recently when working on https://review.typo3.org/c/Packages/TYPO3.CMS/+/79912 Got errrors like: The specifier "@typo3/backend/broadcast-message.js" was a bare specifier, but was not remapped to anything. …but everything worked nonetheless (actually with and without the shim) So yea, I agree that we can remove the shim, but I need to check some details first.
  3. core-ci voted on patch set 1 V +1 07/18/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44231

  4. Andreas Kienast commented on patch set 1 07/18/23, 06:27

    Reply

    Do you by chance have an unclean state due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/80050?
  5. Benjamin Franzke commented on patch set 1 07/18/23, 06:50

    Reply

    no, nothing directly related to these patches, had the mentioned errors a week ago while working on the mentioned patch (copied them from that commit message). (This patch is likely fine, it's just a feeling like: "there is still something wrong with firefox and import maps, but that's most likely only related to script type="module" tags, not import expressions (which we currently only use))
  6. Benjamin Franzke uploaded patch set 2 V +1 07/18/23, 08:53

  7. core-ci voted on patch set 2 V +1 07/18/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44237

  8. Benjamin Franzke commented on patch set 2 07/18/23, 09:14

    ContentSecurityPolicies.php:35

    Note that the comment was wrong as far as I know (I've added it back then, but it seems I've mixed it up with script-src. frame-src is/was actually needed for the list frame, so I've updated the comment and adapted the directive to only allow self, not all blob urls)
  9. Christian Kuhn voted on patch set 2 V +1 CR +1 07/18/23, 09:48

  10. Benjamin Franzke uploaded patch set 3 CR +1 V +1 07/18/23, 10:17

    Resolve Merge Conflict
  11. Christian Kuhn voted on patch set 3 V +1 CR +1 07/18/23, 10:24

  12. core-ci voted on patch set 3 V +1 07/18/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44239

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 07/18/23, 10:31

  14. Andreas Kienast merged patch set 4 07/18/23, 10:31