Review main Merged

80075[TASK] Add property type hints in AssetCollector

Christian Kuhn CR +2 V +2 Easy +10 −29 updated 07/18/23, 11:26

Commit message

All properties in AssetCollector can be safely
type hinted. Also avoids a useless reference.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/18/23, 10:33

  2. Christian Kuhn uploaded patch set 2 07/18/23, 10:35

  3. core-ci voted on patch set 1 V +1 07/18/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44240

  4. core-ci voted on patch set 2 V +1 07/18/23, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44241

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/18/23, 11:12

  6. Oliver Klee voted on patch set 2 V +1 CR +1 07/18/23, 11:24

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 07/18/23, 11:26

  8. Stefan Bürk merged patch set 3 07/18/23, 11:26