80076[TASK] Use more DI in FE RequestHandler
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1722
-
Christian Kuhn uploaded patch set 1 07/18/23, 11:28
-
Oliver Klee voted on patch set 1 CR +1 07/18/23, 11:33
-
Oliver Klee updated the commit message in patch set 2
CR +107/18/23, 11:34 -
Oliver Klee voted on patch set 2 CR +1 07/18/23, 11:34
-
core-ci voted on patch set 1 V -1 07/18/23, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44242
-
Oliver Klee commented on patch set 2 CR -1 07/18/23, 11:39
It looks like we need to adapt some tests. -
core-ci voted on patch set 2 V -1 07/18/23, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44244
-
Benjamin Franzke commented on patch set 2 CR -1 07/18/23, 12:32
Sorry, but FE RequestHandler currently needs to be instantiable without symfony DI (for the FIRST_INSTALL redirect to installtool case). Until then we need it to be defined in ServiceProvider.php – at least as a fallback/noop RequestHandler (added via service provider extension only if symfony DI is not loaded – contact me, if this is too unclar) – which would actually just work right now and would be a good solution. -
Christian Kuhn commented on patch set 2 07/18/23, 12:37
Reply
ah. thanks! i see. will adapt. -
Benjamin Franzke uploaded patch set 3
CR -1V -107/18/23, 12:53 -
Benjamin Franzke commented on patch set 3 07/18/23, 12:53
Reply
Added a fallback request handler. This should make the tests happy.Services.yaml:51Why shared false? We *want* services to be shared, whenever possible. Removed now. -
core-ci voted on patch set 3 V -1 07/18/23, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44250
-
Benjamin Franzke uploaded patch set 4
CR +1V +107/18/23, 14:41 -
core-ci voted on patch set 4 V +1 07/18/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44262
-
Oliver Klee voted on patch set 4 V +1 07/18/23, 14:50
-
Christian Kuhn updated the commit message in patch set 5
CR +1V +107/19/23, 06:23 -
Benjamin Franzke voted on patch set 5 V +1 CR +1 07/19/23, 06:29
-
core-ci voted on patch set 5 V +1 07/19/23, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44290
-
Stefan Bürk voted on patch set 5 V +1 CR +1 07/19/23, 07:07
-
Christian Kuhn voted on patch set 5 V +2 CR +2 07/19/23, 07:29
-
Christian Kuhn merged patch set 6 07/19/23, 07:30