Review main Merged

80076[TASK] Use more DI in FE RequestHandler

Christian Kuhn CR +2 V +2 Normal +52 −37 updated 07/19/23, 07:30

Commit message

Runtime static `FilePathSanitizer` and stateless
`TypoScriptService` can be injected in ext:frontend
`RequestHandler`. Also, the `ServiceProvider` entry
is useless since the class implements
`RequestHandlerInterface`, which sets those classes
public.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1722

  1. Christian Kuhn uploaded patch set 1 07/18/23, 11:28

  2. Oliver Klee voted on patch set 1 CR +1 07/18/23, 11:33

  3. Oliver Klee updated the commit message in patch set 2 CR +1 07/18/23, 11:34

  4. Oliver Klee voted on patch set 2 CR +1 07/18/23, 11:34

  5. core-ci voted on patch set 1 V -1 07/18/23, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44242

  6. Oliver Klee commented on patch set 2 CR -1 07/18/23, 11:39

    It looks like we need to adapt some tests.
  7. core-ci voted on patch set 2 V -1 07/18/23, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44244

  8. Benjamin Franzke commented on patch set 2 CR -1 07/18/23, 12:32

    Sorry, but FE RequestHandler currently needs to be instantiable without symfony DI (for the FIRST_INSTALL redirect to installtool case). Until then we need it to be defined in ServiceProvider.php – at least as a fallback/noop RequestHandler (added via service provider extension only if symfony DI is not loaded – contact me, if this is too unclar) – which would actually just work right now and would be a good solution.
  9. Christian Kuhn commented on patch set 2 07/18/23, 12:37

    Reply

    ah. thanks! i see. will adapt.
  10. Benjamin Franzke uploaded patch set 3 CR -1 V -1 07/18/23, 12:53

  11. Benjamin Franzke commented on patch set 3 07/18/23, 12:53

    Reply

    Added a fallback request handler. This should make the tests happy.

    Services.yaml:51

    Why shared false? We *want* services to be shared, whenever possible. Removed now.
  12. core-ci voted on patch set 3 V -1 07/18/23, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44250

  13. Benjamin Franzke uploaded patch set 4 CR +1 V +1 07/18/23, 14:41

  14. Benjamin Franzke commented on patch set 4 07/18/23, 14:43

    Reply

    Done

    Services.yaml:51 Reply

    Done
  15. core-ci voted on patch set 4 V +1 07/18/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44262

  16. Oliver Klee voted on patch set 4 V +1 07/18/23, 14:50

  17. Christian Kuhn updated the commit message in patch set 5 CR +1 V +1 07/19/23, 06:23

  18. Benjamin Franzke voted on patch set 5 V +1 CR +1 07/19/23, 06:29

  19. core-ci voted on patch set 5 V +1 07/19/23, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44290

  20. Stefan Bürk voted on patch set 5 V +1 CR +1 07/19/23, 07:07

  21. Christian Kuhn voted on patch set 5 V +2 CR +2 07/19/23, 07:29

  22. Christian Kuhn merged patch set 6 07/19/23, 07:30