Review main Merged

80081[BUGFIX] Restore accidently removed `in()` expression wrapper

Stefan Bürk CR +2 V +2 Easy +4 −1 updated 07/18/23, 14:23

Commit message

With #86859 array lists which can become quite large have been replaced
using `$queryBuilder->quoteArrayBasedValueListToIntegerList($idList)`
to reduce the consumed placeholders.

However, one replacement removed accidently the wrapping `->in(...)`
expression. This has been detected during the backport process, which
means that we need to restore this only for `main`. Backports have
been fixed directly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 07/18/23, 13:48

  2. core-ci voted on patch set 1 V +1 07/18/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44256

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 07/18/23, 14:02

  4. Oliver Klee voted on patch set 1 V +1 CR +1 07/18/23, 14:03

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 07/18/23, 14:23

  6. Stefan Bürk merged patch set 2 07/18/23, 14:23