Review main Merged

80087[BUGFIX] Ensure placeholders are replaced when loading `settings.yaml`

Gerrit Mohrmann CR +2 V +2 Easy +7 −1 updated 07/19/23, 22:29

Commit message

Site settings have been extracted from `config.yaml` with #99047
by providing a dedicated `UpgradeWizard`. Site settings are now
read from the `settings.yaml` in the site configuration folder,
if it exists.

During editing site configuration within the GUI, the deprecated
settings in the `config.yaml` has been updated. That missbehaviour
was corrected with #100162.

Before these changes, symfony yaml placeholder have been replaced
except if the SiteConfiguration have been loaded in edit context
or context needing the raw configuraiton (couple of form engine
elements). Loaded from `settings.yaml` the placeholder are not
replaced anymore.

This change now ensures that site settings loaded from the
`settings.yaml` are loaded with replacing placeholder again.
Additionally, a todo-comment is added to raise some precaution
for an eventually coming settings GUI for the `settings.yaml`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 912

  1. Gerrit Mohrmann uploaded patch set 1 07/18/23, 20:03

  2. core-ci voted on patch set 1 V +1 07/18/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44281

  3. Stefan Bürk commented on patch set 1 CR -1 07/19/23, 08:27

    on it ...
  4. Stefan Bürk uploaded patch set 2 CR -1 V +1 07/19/23, 11:31

  5. core-ci voted on patch set 2 V +1 07/19/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44308

  6. Stefan Bürk uploaded patch set 3 V +1 07/19/23, 11:47

  7. core-ci voted on patch set 3 V +1 07/19/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44310

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 07/19/23, 11:58

  9. Benni Mack voted on patch set 3 CR +1 07/19/23, 22:07

  10. Benni Mack voted on patch set 3 V +1 07/19/23, 22:07

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 07/19/23, 22:26

  12. Stefan Bürk merged patch set 4 07/19/23, 22:29