Review 11.5 Merged

80088[TASK] Drop redundant condition from TransportFactory

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/19/23, 08:44

Commit message

The variable `$port` in the changed code is an array element
from the return value of `GeneralUtility::trimExplode()` with
the `$removeEmptyValues` argument set to `true`. Hence it
is ensured to not be an empty string.

This change should be backported as it otherwise would block
improvements for the type annotations of
`GeneralUtility::trimExplode()`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/19/23, 08:19

  2. core-ci voted on patch set 1 V +1 07/19/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44293

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/19/23, 08:44

  4. Christian Kuhn merged patch set 2 07/19/23, 08:44