Review main Merged Breaking

80102[!!!][TASK] Remove leftover $fetchAllFields in RelationHandler

Nikita Hovratov CR +2 V +2 Normal +46 −19 updated 07/21/23, 08:50

Commit message

RelationHandler had an unused property `$fetchAllFields` since
TYPO3 11.5.0. The related method `setFetchAllFields` has been removed
with it.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 89

  1. Nikita Hovratov uploaded patch set 1 07/20/23, 14:13

  2. core-ci voted on patch set 1 V +1 07/20/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44350

  3. Oliver Klee voted on patch set 1 V +1 CR +1 07/20/23, 15:37

  4. Nikita Hovratov commented on patch set 1 07/20/23, 16:01

    @benni Did you actually intend to remove this property?
  5. Alexander Schnitzler voted on patch set 1 V +1 CR +1 07/21/23, 06:08

  6. Jörg Bösche voted on patch set 1 CR +1 07/21/23, 07:45

  7. Benni Mack commented on patch set 1 CR +1 07/21/23, 08:28

    Yes. can be removed.
  8. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/21/23, 08:50

  9. Nikita Hovratov merged patch set 2 07/21/23, 08:50