80106[TASK] Remove backwards-compat files array in extbase
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Susi Moog +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1522
-
Susi Moog uploaded patch set 1 07/21/23, 07:41
-
core-ci voted on patch set 1 V -1 07/21/23, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44367
-
Christian Kuhn marked it ready for review 07/28/23, 16:47
-
Christian Kuhn updated the commit message in patch set 2
V -107/28/23, 16:47 -
Christian Kuhn rebased onto patch set 3 07/28/23, 16:47
-
core-ci voted on patch set 2 V -1 07/28/23, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44679
-
core-ci voted on patch set 3 V -1 07/28/23, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44680
-
Christian Kuhn updated the commit message in patch set 4
V -107/31/23, 09:52 -
core-ci voted on patch set 4 V -1 07/31/23, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44791
-
Christian Kuhn uploaded patch set 5
V -107/31/23, 11:16 -
core-ci voted on patch set 5 V +1 07/31/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44800
-
Christian Kuhn uploaded patch set 6
V +107/31/23, 11:29 -
Oliver Klee commented on patch set 6 07/31/23, 11:31
Looks good! Added one minor comment regarding the tests.RequestBuilderTest.php:254I propose we use `assertInstanceOf` here. Then the type also gets checked (and we still provided PHPStan with the type information). -
Susi Moog commented on patch set 6 V +1 CR +1 07/31/23, 11:36
Thanks for finishing -
core-ci voted on patch set 6 V +1 07/31/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44803
-
Christian Kuhn commented on patch set 6 07/31/23, 11:40
RequestBuilderTest.php:254ReplyDone -
Christian Kuhn uploaded patch set 7
CR +1V +107/31/23, 11:40 -
Susi Moog voted on patch set 7 V +1 CR +1 07/31/23, 11:42
-
Christian Kuhn voted on patch set 7 V +1 CR +1 07/31/23, 11:44
-
core-ci voted on patch set 7 V +1 07/31/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44805
-
Stefan Bürk voted on patch set 7 V +2 CR +2 07/31/23, 11:57
-
Stefan Bürk merged patch set 8 07/31/23, 11:57