Review main Merged

80106[TASK] Remove backwards-compat files array in extbase

Susi Moog CR +2 V +2 Normal +34 −72 updated 07/31/23, 11:57

Commit message

Removal of having extbase files as
request arguments, use request->getUploadeFiles()
instead.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1522

  1. Susi Moog uploaded patch set 1 07/21/23, 07:41

  2. core-ci voted on patch set 1 V -1 07/21/23, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44367

  3. Christian Kuhn marked it ready for review 07/28/23, 16:47

  4. Christian Kuhn updated the commit message in patch set 2 V -1 07/28/23, 16:47

  5. Christian Kuhn rebased onto patch set 3 07/28/23, 16:47

  6. core-ci voted on patch set 2 V -1 07/28/23, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44679

  7. core-ci voted on patch set 3 V -1 07/28/23, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44680

  8. Christian Kuhn updated the commit message in patch set 4 V -1 07/31/23, 09:52

  9. core-ci voted on patch set 4 V -1 07/31/23, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44791

  10. Christian Kuhn uploaded patch set 5 V -1 07/31/23, 11:16

  11. core-ci voted on patch set 5 V +1 07/31/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44800

  12. Christian Kuhn uploaded patch set 6 V +1 07/31/23, 11:29

  13. Oliver Klee commented on patch set 6 07/31/23, 11:31

    Looks good! Added one minor comment regarding the tests.

    RequestBuilderTest.php:254

    I propose we use `assertInstanceOf` here. Then the type also gets checked (and we still provided PHPStan with the type information).
  14. Susi Moog commented on patch set 6 V +1 CR +1 07/31/23, 11:36

    Thanks for finishing
  15. core-ci voted on patch set 6 V +1 07/31/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44803

  16. Christian Kuhn commented on patch set 6 07/31/23, 11:40

    RequestBuilderTest.php:254 Reply

    Done
  17. Christian Kuhn uploaded patch set 7 CR +1 V +1 07/31/23, 11:40

  18. Susi Moog voted on patch set 7 V +1 CR +1 07/31/23, 11:42

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 07/31/23, 11:44

  20. core-ci voted on patch set 7 V +1 07/31/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44805

  21. Stefan Bürk voted on patch set 7 V +2 CR +2 07/31/23, 11:57

  22. Stefan Bürk merged patch set 8 07/31/23, 11:57