Review main Merged

80109[TASK] Use silence operator `@` for test setup

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 07/24/23, 06:27

Commit message

PHP8.3 emits a warning for content handed over to
unserialize() which contains superflous content at
the end.

The silence operator `@` is now used to suppress
the test setup unserialize() to avoid this exact
warning as preparation for PHP8.3 introduction.

Can be verified before and after by executing:

> Build/Scripts/runTests.sh -p 8.3 -s unitDeprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1518

  1. Stefan Bürk uploaded patch set 1 07/21/23, 14:58

  2. core-ci voted on patch set 1 V +1 07/21/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44392

  3. Oliver Klee commented on patch set 1 07/21/23, 20:59

    Please let‘s have a shorter one-line subject for the commit message.
  4. Stefan Bürk commented on patch set 1 07/21/23, 21:01

    Reply

    what the heck ... happened here. Fill fix it.
  5. Stefan Bürk updated the commit message in patch set 2 V +1 07/21/23, 21:01

  6. Stefan Bürk commented on patch set 2 07/21/23, 21:01

    Reply

    Done
  7. Oliver Klee voted on patch set 2 V +1 CR +1 07/21/23, 21:07

  8. core-ci voted on patch set 2 V +1 07/21/23, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44400

  9. Torben Hansen commented on patch set 2 07/22/23, 12:51

    ReflectionServiceTest.php:34

    Typo, should be "unneeded"
  10. Stefan Bürk uploaded patch set 3 CR +1 V +1 07/22/23, 13:25

  11. Stefan Bürk commented on patch set 3 07/22/23, 13:25

    ReflectionServiceTest.php:34 Reply

    Done
  12. core-ci voted on patch set 3 V +1 07/22/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44421

  13. Torben Hansen voted on patch set 3 V +1 CR +1 07/22/23, 14:44

  14. Oliver Klee voted on patch set 3 V +1 CR +1 07/23/23, 09:59

  15. Benni Mack voted on patch set 3 V +1 CR +1 07/23/23, 19:54

  16. Georg Ringer voted on patch set 3 V +1 CR +1 07/24/23, 06:14

  17. Stefan Bürk voted on patch set 3 V +2 CR +2 07/24/23, 06:27

  18. Stefan Bürk merged patch set 4 07/24/23, 06:27