Review main Merged

80112[BUGFIX] Ensure CKEditor ui language is always set

Torben Hansen CR +2 V +2 Easy +3 −1 updated 08/17/23, 21:20

Commit message

If the CKEditor configuration has a language configuration, but does not
define the `ui` language setting, no fallback language is added to the
editor configuration and an undefined array key exception is thrown.

This change ensures, that the `ui` language is properly set when
the editor configuration has a language configuration and the
`ui` language is missing.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Torben Hansen uploaded patch set 1 07/22/23, 12:23

  2. core-ci voted on patch set 1 V +1 07/22/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44417

  3. Sybille Peters updated the commit message in patch set 2 V +1 07/23/23, 12:47

  4. core-ci voted on patch set 2 V +1 07/23/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44437

  5. Benni Mack voted on patch set 2 CR +1 07/24/23, 12:22

  6. Oliver Klee voted on patch set 2 CR +1 07/24/23, 14:12

  7. Georg Tiefenbrunn voted on patch set 2 CR +1 08/16/23, 16:29

  8. Andreas Nedbal rebased onto patch set 3 CR +1 V +1 08/17/23, 21:11

  9. core-ci voted on patch set 3 V +1 08/17/23, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45591

  10. Andreas Nedbal voted on patch set 3 V +2 CR +2 08/17/23, 21:20

  11. Andreas Nedbal merged patch set 4 08/17/23, 21:20