80116[BUGFIX] Alert about deleting content elements with references
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 4
- Bug #101414Alert dialog does not show information about references inline delete button in page module is used (v11)
- Bug #101411Message that there are references which point to this record is not always displayed when trying to delete a record
- Task #92670Delete and paste dialogues don't include content element title
- Task #94780Show title/uid when on delete confirmation modal in layout view
Files 2
Review log 1625
-
Sybille Peters uploaded patch set 1 07/22/23, 13:28
-
Sybille Peters updated the commit message in patch set 2 07/22/23, 13:34
-
Sybille Peters updated the commit message in patch set 3 07/22/23, 13:40
-
Sybille Peters updated the commit message in patch set 4 07/22/23, 13:47
-
core-ci voted on patch set 2 V -1 07/22/23, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44425
-
core-ci voted on patch set 1 V -1 07/22/23, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44424
-
core-ci voted on patch set 3 V -1 07/22/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44426
-
core-ci voted on patch set 4 V -1 07/22/23, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44427
-
Sybille Peters uploaded patch set 5
V -107/22/23, 16:22 -
core-ci voted on patch set 5 V +1 07/22/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44429
-
Sybille Peters updated the commit message in patch set 6
V +107/23/23, 06:39 -
core-ci voted on patch set 6 V +1 07/23/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44434
-
Jörg Bösche voted on patch set 6 CR +1 08/10/23, 13:23
-
Sybille Peters updated the commit message in patch set 7
CR +1V +109/17/23, 14:10 -
core-ci voted on patch set 7 V +1 09/17/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46632
-
Sybille Peters rebased onto patch set 8
V +111/20/23, 12:21 -
core-ci voted on patch set 8 V +1 11/20/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49125
-
Garvin Hicking commented on patch set 8 11/21/23, 17:32
I'll push a patchset containing my suggestions, hope that's ok.GridColumnItem.php:152This language string in v11 only has the content: `Are you sure you want to delete this record?` but in main (maybe v12) too it has: `Are you sure you want to delete the record '%s'?` So either we would need to backport a language string (probably harder due to v11 maintenance state), or the whole code above could be shortened to not address `$recordInfo`?GridColumnItem.php:354Actually the BackendUtility::referenceCount() method can count the references itself, if the parameter is not specified - to reduce complexity, I would suggest to use that?Header.html:27This is a duplicate line, probably by accident, it's also used two lines down? -
Garvin Hicking uploaded patch set 9
V +111/21/23, 17:39 -
Garvin Hicking commented on patch set 9 V +1 CR +1 11/21/23, 17:42
Please check if that works out for you (it does for me *g*) -
core-ci voted on patch set 9 V +1 11/21/23, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49270
-
Christian Kuhn commented on patch set 9 11/21/23, 17:57
GridColumnItem.php:152ReplyDoneHeader.html:27ReplyDone -
Christian Kuhn commented on patch set 9 11/21/23, 17:57
GridColumnItem.php:354ReplyDone -
Christian Kuhn voted on patch set 9 V +2 CR +2 11/21/23, 18:01
-
Christian Kuhn merged patch set 10 11/21/23, 18:01