Review 11.5 Merged

80116[BUGFIX] Alert about deleting content elements with references

Sybille Peters CR +2 V +2 Easy +17 −1 updated 11/21/23, 18:01

Commit message

If deleting content elements which have references
to it, a confirm dialog is displayed asking if the
element should really be deleted. Usually, the
dialog message contains information about existing
references (if there are references).

This was not the case if the content element is deleted
by using the inline delete button in the page module
in TYPO3 v11.

This behaviour was already improved and streamlined
in TYPO3 v12.

This is a partial backport of functionality in patch
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001
to backport the most critical functionality
improvement.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 1625

  1. Sybille Peters uploaded patch set 1 07/22/23, 13:28

  2. Sybille Peters updated the commit message in patch set 2 07/22/23, 13:34

  3. Sybille Peters updated the commit message in patch set 3 07/22/23, 13:40

  4. Sybille Peters updated the commit message in patch set 4 07/22/23, 13:47

  5. core-ci voted on patch set 2 V -1 07/22/23, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44425

  6. core-ci voted on patch set 1 V -1 07/22/23, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44424

  7. core-ci voted on patch set 3 V -1 07/22/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44426

  8. core-ci voted on patch set 4 V -1 07/22/23, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44427

  9. Sybille Peters uploaded patch set 5 V -1 07/22/23, 16:22

  10. core-ci voted on patch set 5 V +1 07/22/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44429

  11. Sybille Peters updated the commit message in patch set 6 V +1 07/23/23, 06:39

  12. core-ci voted on patch set 6 V +1 07/23/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44434

  13. Jörg Bösche voted on patch set 6 CR +1 08/10/23, 13:23

  14. Sybille Peters updated the commit message in patch set 7 CR +1 V +1 09/17/23, 14:10

  15. core-ci voted on patch set 7 V +1 09/17/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46632

  16. Sybille Peters rebased onto patch set 8 V +1 11/20/23, 12:21

  17. core-ci voted on patch set 8 V +1 11/20/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49125

  18. Garvin Hicking commented on patch set 8 11/21/23, 17:32

    I'll push a patchset containing my suggestions, hope that's ok.

    GridColumnItem.php:152

    This language string in v11 only has the content: `Are you sure you want to delete this record?` but in main (maybe v12) too it has: `Are you sure you want to delete the record '%s'?` So either we would need to backport a language string (probably harder due to v11 maintenance state), or the whole code above could be shortened to not address `$recordInfo`?

    GridColumnItem.php:354

    Actually the BackendUtility::referenceCount() method can count the references itself, if the parameter is not specified - to reduce complexity, I would suggest to use that?

    Header.html:27

    This is a duplicate line, probably by accident, it's also used two lines down?
  19. Garvin Hicking uploaded patch set 9 V +1 11/21/23, 17:39

  20. Garvin Hicking commented on patch set 9 V +1 CR +1 11/21/23, 17:42

    Please check if that works out for you (it does for me *g*)
  21. core-ci voted on patch set 9 V +1 11/21/23, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49270

  22. Christian Kuhn commented on patch set 9 11/21/23, 17:57

    GridColumnItem.php:152 Reply

    Done

    Header.html:27 Reply

    Done
  23. Christian Kuhn commented on patch set 9 11/21/23, 17:57

    GridColumnItem.php:354 Reply

    Done
  24. Christian Kuhn voted on patch set 9 V +2 CR +2 11/21/23, 18:01

  25. Christian Kuhn merged patch set 10 11/21/23, 18:01