Review main Merged

80117[TASK] Remove unnecessary typecasts in ext:beuser

Torben Hansen CR +2 V +2 Easy +4 −5 updated 07/23/23, 07:04

Commit message

The typecasts for `$demand->getBackendUserGroup()` can safely
be removed, since the return type is always an integer.

Additionally, the todo about refactoring to n:m relations has
been removed, since there currently is no plan to refactor
the `be_users.usergroup` field to use n:m relations.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Sybille Peters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 07/23/23, 05:27

  2. core-ci voted on patch set 1 V +1 07/23/23, 05:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44433

  3. Sybille Peters voted on patch set 1 V +1 CR +1 07/23/23, 06:27

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 07/23/23, 07:04

  5. Stefan Bürk merged patch set 2 07/23/23, 07:04