80119[TASK] Replace usage of deprecated Property::getElementType()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+4 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php+9 −27
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php3+8 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/Domain/Model/Model.php+1 −1
Review log 1113
-
Alexander Schnitzler uploaded patch set 1 07/23/23, 15:37
-
Alexander Schnitzler wrote 07/23/23, 15:37
Topic set to extbase -
Alexander Schnitzler commented on patch set 1 07/23/23, 15:40
ValidatorResolver.php:131Technically we don't need the `isCollection` check here because that's already checked inside `getPrimaryCollectionValueType` call but it's a bit easier to read. Please decide someone else if we drop it nontheless. -
core-ci voted on patch set 1 V -1 07/23/23, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44439
-
Alexander Schnitzler uploaded patch set 2
V -107/23/23, 15:52 -
core-ci voted on patch set 2 V +1 07/23/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44440
-
Oliver Klee commented on patch set 2 07/23/23, 17:27
ValidatorResolver.php:131ReplyI'd be in favor of keeping it: "Readability over briefness" -
Oliver Klee voted on patch set 2 V +1 CR +1 07/23/23, 20:39
-
Oliver Klee commented on patch set 2 07/24/23, 08:16
ValidatorResolver.php:131ReplyMarking as resolved so we can move this forward. (If anything objects, they are free to comment.) -
Benni Mack voted on patch set 2 V +2 CR +2 07/25/23, 06:23
-
Benni Mack merged patch set 3 07/25/23, 06:23
-
Christian Kuhn commented on patch set 3 07/25/23, 08:02
Related: #100963 -
Christian Kuhn commented on patch set 3 07/25/23, 08:04
Related: #98132