Review main Merged

80119[TASK] Replace usage of deprecated Property::getElementType()

Alexander Schnitzler CR +2 V +2 Normal +22 −32 updated 07/25/23, 08:04

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Alexander Schnitzler uploaded patch set 1 07/23/23, 15:37

  2. Alexander Schnitzler wrote 07/23/23, 15:37

    Topic set to extbase
  3. Alexander Schnitzler commented on patch set 1 07/23/23, 15:40

    ValidatorResolver.php:131

    Technically we don't need the `isCollection` check here because that's already checked inside `getPrimaryCollectionValueType` call but it's a bit easier to read. Please decide someone else if we drop it nontheless.
  4. core-ci voted on patch set 1 V -1 07/23/23, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44439

  5. Alexander Schnitzler uploaded patch set 2 V -1 07/23/23, 15:52

  6. core-ci voted on patch set 2 V +1 07/23/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44440

  7. Oliver Klee commented on patch set 2 07/23/23, 17:27

    ValidatorResolver.php:131 Reply

    I'd be in favor of keeping it: "Readability over briefness"
  8. Oliver Klee voted on patch set 2 V +1 CR +1 07/23/23, 20:39

  9. Oliver Klee commented on patch set 2 07/24/23, 08:16

    ValidatorResolver.php:131 Reply

    Marking as resolved so we can move this forward. (If anything objects, they are free to comment.)
  10. Benni Mack voted on patch set 2 V +2 CR +2 07/25/23, 06:23

  11. Benni Mack merged patch set 3 07/25/23, 06:23

  12. Christian Kuhn commented on patch set 3 07/25/23, 08:02

    Related: #100963
  13. Christian Kuhn commented on patch set 3 07/25/23, 08:04

    Related: #98132