Review 12.4 Merged

80124[TASK] Replace docker-compose in runTests.sh

Stefan Bürk CR +2 V +2 Expert +304 −1743 updated 07/25/23, 14:21

Commit message

runTests.sh uses of docker-compose to run tests.

The patch ditches docker-compose in favor of
direct docker cli commands for the following
reasons:

* runTests.sh is more concise and does not
  need to deal with writing a .env for
  docker-compose anymore.
* Establish a foundation to use podman
  as alternative container runner.
* Ditch the lengthy docker-compose.yml file
  that repeats things over and over again.
* Better control of running containers.
* Allow running multiple runTests.sh instances
  in parallel without disturbing each other by
  establishing unique names for networks and
  containers.
* Minor performance improvements by getting
  rid of the docker-compose python overhead.
* Simplified quoting in scripts.
* Less path headaches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Stefan Bürk uploaded patch set 1 07/24/23, 06:40

  2. Stefan Bürk uploaded patch set 2 07/24/23, 06:41

  3. core-ci voted on patch set 2 V +1 07/24/23, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44452

  4. Stefan Bürk uploaded patch set 3 V +1 07/24/23, 07:00

  5. core-ci voted on patch set 3 V +1 07/24/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44454

  6. Christian Kuhn uploaded patch set 4 V +1 07/25/23, 12:52

  7. core-ci voted on patch set 4 V +1 07/25/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44529

  8. core-ci voted on patch set 4 V -1 07/25/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44535

  9. core-ci voted on patch set 4 V +1 07/25/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44535

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 07/25/23, 14:14

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 07/25/23, 14:17

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 07/25/23, 14:21

  13. Christian Kuhn merged patch set 5 07/25/23, 14:21