Review 11.5 Merged

80126[TASK] Replace docker-compose in runTests.sh

Stefan Bürk CR +2 V +2 Expert +330 −1758 updated 07/25/23, 14:21

Commit message

runTests.sh uses of docker-compose to run tests.

The patch ditches docker-compose in favor of
direct docker cli commands for the following
reasons:

* runTests.sh is more concise and does not
  need to deal with writing a .env for
  docker-compose anymore.
* Establish a foundation to use podman
  as alternative container runner.
* Ditch the lengthy docker-compose.yml file
  that repeats things over and over again.
* Better control of running containers.
* Allow running multiple runTests.sh instances
  in parallel without disturbing each other by
  establishing unique names for networks and
  containers.
* Minor performance improvements by getting
  rid of the docker-compose python overhead.
* Simplified quoting in scripts.
* Less path headaches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1017

  1. Stefan Bürk uploaded patch set 1 07/24/23, 07:53

  2. Stefan Bürk uploaded patch set 2 07/24/23, 08:01

  3. core-ci voted on patch set 1 V -1 07/24/23, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44456

  4. core-ci voted on patch set 2 V -1 07/24/23, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44457

  5. Stefan Bürk uploaded patch set 3 V -1 07/24/23, 08:16

  6. Stefan Bürk uploaded patch set 4 07/24/23, 08:22

  7. core-ci voted on patch set 3 V -1 07/24/23, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44459

  8. core-ci voted on patch set 4 V -1 07/24/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44460

  9. Stefan Bürk uploaded patch set 5 V -1 07/24/23, 08:30

  10. core-ci voted on patch set 5 V +1 07/24/23, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44462

  11. Christian Kuhn uploaded patch set 6 V +1 07/25/23, 13:32

  12. core-ci voted on patch set 6 V +1 07/25/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44536

  13. core-ci commented on patch set 6 07/25/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44541

  14. Christian Kuhn voted on patch set 6 V +1 CR +1 07/25/23, 14:14

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 07/25/23, 14:17

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 07/25/23, 14:21

  17. Christian Kuhn merged patch set 7 07/25/23, 14:21