Review 12.4 Merged

80131[BUGFIX] Allow attributes for anchors in ckeditor

Benjamin Franzke CR +2 V +2 Easy +4 −5 updated 07/24/23, 16:43

Commit message

Ckeditor 5 is used since TYPO3 12 which has significantly changed
how elements in the DOM are handled.

The `a` element is handled in the plugin typo3-link, but it did not
handle some attributes correctly, specifically:

- class
- rel
- target

This resulted in only `href` and `title` being persisted when saving
or switching between source and normal mode.

This is now fixed, so that all 5 attributes will be handled
correctly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 07/24/23, 15:52

  2. core-ci voted on patch set 1 V +1 07/24/23, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44481

  3. Benjamin Franzke merged patch set 2 07/24/23, 16:43