Review 11.5 Merged

80138[TASK] Improve return type annotations for GU::trimExplode

Oliver Klee CR +2 V +2 Easy +5 −2 updated 07/25/23, 14:08

Commit message

This particularly helps PHPStan in extensions that call those methods
detect unnecessary checks for empty strings if
`GU::trimExplode` is called with `$removeEmptyValues = true`.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Oliver Klee commented on patch set 1 07/25/23, 12:50

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * typo3/sysext/core/Classes/Utility/GeneralUtility.php
  2. Oliver Klee uploaded patch set 2 07/25/23, 13:06

  3. Oliver Klee marked it ready for review 07/25/23, 13:07

  4. core-ci voted on patch set 1 V -1 07/25/23, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44527

  5. Oliver Klee updated the commit message in patch set 3 07/25/23, 13:13

  6. core-ci voted on patch set 3 V -1 07/25/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44534

  7. Christian Kuhn uploaded patch set 4 V -1 07/25/23, 13:41

  8. core-ci voted on patch set 4 V +1 07/25/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44539

  9. Christian Kuhn voted on patch set 4 V +2 CR +2 07/25/23, 14:08

  10. Christian Kuhn merged patch set 5 07/25/23, 14:08