Review 11.5 Merged

80156[SECURITY] Avoid out-of-scope page access for non-matching site

Oliver Hader CR +2 V +2 Hard +426 −71 updated 07/25/23, 08:33

Commit message

This change disallows calling an URI with page-id query parameters
that are not part of a particular site - for instance the following
URL `https://example.org/?id=3000&L=0` has two aspects:

* the site `example.org` has the root page-id 1000
* the site `internal.example.org` has the root page-id 3000

The example above allows to call a page-id for an internal site,
by using a valid and public entry point.

The new feature flag
`security.frontend.allowInsecureSiteResolutionByQueryParameters`
allows to control this behavior for backward compatibility reasons.
Per default `allowInsecureSiteResolutionByQueryParameters` is disabled.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 9

Review log 34

  1. Oliver Hader uploaded patch set 1 07/25/23, 08:03

  2. Oliver Hader commented on patch set 1 V +2 CR +2 07/25/23, 08:03

    Auto-approved
  3. Oliver Hader merged patch set 2 07/25/23, 08:03

  4. core-ci voted on patch set 1 V +1 07/25/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44501