80159[SECURITY] Avoid out-of-scope page access for non-matching site
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
Issues 1
Files 9
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+123 −63
- typo3/sysext/core/Classes/Routing/SiteRouteResult.php+11 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+20 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestAllowInsecureSiteResolutionByQueryParametersDisabledTest.phpnew+116 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestAllowInsecureSiteResolutionByQueryParametersEnabledTest.phpnew+118 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+6 −0
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+22 −4
Review log 34
-
Oliver Hader uploaded patch set 1 07/25/23, 08:03
-
Oliver Hader commented on patch set 1 V +2 CR +2 07/25/23, 08:03
Auto-approved -
Oliver Hader merged patch set 2 07/25/23, 08:03
-
core-ci voted on patch set 1 V +1 07/25/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44504