80167[BUGFIX] Display preview image of media resource
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Henning Liebe +1
- HOJA M A +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Henning Liebe +1
- HOJA M A +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1216
-
Simon Schaufelberger uploaded patch set 1 07/25/23, 09:33
-
core-ci voted on patch set 1 V +1 07/25/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44514
-
Simon Schaufelberger updated the commit message in patch set 2
V +107/25/23, 10:14 -
core-ci voted on patch set 2 V +1 07/25/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44516
-
Thomas Hohn voted on patch set 2 CR +1 08/03/23, 10:47
-
Andreas Kienast commented on patch set 2 CR -1 08/03/23, 16:35
Thanks. This could also be done in at least Clipboard.php and FileInfoElement.php. Also, I personally don't consider it critical for v11. -
Andreas Kienast uploaded patch set 3
CR +1V +108/03/23, 19:08 -
core-ci voted on patch set 3 V -1 08/03/23, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44948
-
HOJA M A commented on patch set 3 V +1 CR +1 08/03/23, 19:33
I tested with media and clipboard preview images. It works fine.Code also looking good to me. -
core-ci voted on patch set 3 V +1 08/03/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44948
-
Henning Liebe commented on patch set 3 V +1 CR +1 08/03/23, 19:54
Looks good to me -
Henning Liebe commented on patch set 3 08/03/23, 19:55
Reply
resolved -
Oli Bartsch voted on patch set 3 V +1 CR +1 08/03/23, 20:59
-
Andreas Kienast commented on patch set 3 CR +2 08/03/23, 21:13
Waiting for green backports -
Andreas Kienast voted on patch set 3 V +2 08/03/23, 21:32
-
Andreas Kienast merged patch set 4 08/03/23, 21:32