Review main Merged

80171[BUGFIX] Apply proper url encoding to query params in form engine popups

Benjamin Franzke CR +2 V +2 Easy +13 −2 updated 07/25/23, 21:47

Commit message

With #101231 a missing URL encoding in FormEngine was triggered
which caused contents like "svg;disallowed=|irre-object-id" to be
added to bparams which got transformed into "svg&disallowed" in
some setups (ddev, most likely caused by the ddev-router-proxy).

This "change" causes the irre object id to be cut off from the
bparams in IREE file list element browser, which is why "select"
actions on file list elements were silently ignored.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Kevin Appelt +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
    • Kevin Appelt +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Benjamin Franzke uploaded patch set 1 07/25/23, 18:55

  2. core-ci voted on patch set 1 V +1 07/25/23, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44551

  3. Kevin Appelt voted on patch set 1 V +1 CR +1 07/25/23, 19:05

  4. Jasmina Ließmann voted on patch set 1 V +1 07/25/23, 19:47

  5. Benni Mack voted on patch set 1 V +1 CR +1 07/25/23, 19:49

  6. Stefan Bürk voted on patch set 1 CR +1 07/25/23, 20:00

  7. Stefan Bürk commented on patch set 1 V +1 07/25/23, 20:07

    installed to verify before & after
  8. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/25/23, 21:47

  9. Benjamin Franzke merged patch set 2 07/25/23, 21:47