80173[BUGFIX] Suppress "not found" message during "typo3 setup"
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Stefan Bürk +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Jochen Roth uploaded patch set 1 07/25/23, 22:34
-
Jochen Roth updated the commit message in patch set 2 07/25/23, 22:35
-
core-ci voted on patch set 1 V +1 07/25/23, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44560
-
core-ci voted on patch set 2 V +1 07/25/23, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44561
-
Oliver Klee commented on patch set 2 07/26/23, 07:27
We'll then need to add `symfony/process` as a dependency for the Core (EXT:core and the "wrapper" Composer package) so we don't rely on a transitive dependency (which might go away at any time). -
Oliver Klee commented on patch set 2 07/26/23, 07:28
Reply
(marking as not resolved) -
Jochen Roth commented on patch set 2 CR -1 07/26/23, 09:22
Will have a closer look to circumvent the symfony/process dependency. -
Stefan Bürk commented on patch set 2 CR -1 07/26/23, 13:40
GraphicsMagickPreset.php:70This whole method is about to find the binary, doing a test command call. I guess we should add kind of checks to it: * `file_exists()` * `is_executable()` before making the thest call with exec and continue the loop early. And avoid the 3rd party dependencie for now.ImageMagick6Preset.php:70This whole method is about to find the binary, doing a test command call. I guess we should add kind of checks to it: * `file_exists()` * `is_executable()` before making the thest call with exec and continue the loop early. And avoid the 3rd party dependencie for now. -
Jochen Roth uploaded patch set 3
CR -1V +107/26/23, 19:22 -
Jochen Roth uploaded patch set 4 07/26/23, 19:24
-
Jochen Roth uploaded patch set 5 07/26/23, 19:25
-
core-ci voted on patch set 3 V +1 07/26/23, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44591
-
core-ci voted on patch set 4 V -1 07/26/23, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44592
-
core-ci voted on patch set 5 V +1 07/26/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44593
-
Oli Bartsch voted on patch set 5 CR +1 07/27/23, 13:51
-
Oliver Klee commented on patch set 5 CR +1 07/27/23, 13:52
GraphicsMagickPreset.php:70ReplyDoneImageMagick6Preset.php:70ReplyDone -
Oliver Klee commented on patch set 5 07/27/23, 13:52
Reply
Done -
Torben Hansen commented on patch set 5 V +1 CR +1 07/27/23, 16:59
Thanks! -
Stefan Bürk voted on patch set 5 V +2 CR +2 07/27/23, 19:22
-
Stefan Bürk merged patch set 6 07/27/23, 19:32