Review main Merged

80173[BUGFIX] Suppress "not found" message during "typo3 setup"

Jochen Roth CR +2 V +2 Easy +13 −2 updated 07/27/23, 19:32

Commit message

Currently, the binary find methods for IM/GM do not
check for binary existence, which leads to a several
messages printed to console.

This has been fixed by adding a pre-check for the
binary prior using it.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Jochen Roth uploaded patch set 1 07/25/23, 22:34

  2. Jochen Roth updated the commit message in patch set 2 07/25/23, 22:35

  3. core-ci voted on patch set 1 V +1 07/25/23, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44560

  4. core-ci voted on patch set 2 V +1 07/25/23, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44561

  5. Oliver Klee commented on patch set 2 07/26/23, 07:27

    We'll then need to add `symfony/process` as a dependency for the Core (EXT:core and the "wrapper" Composer package) so we don't rely on a transitive dependency (which might go away at any time).
  6. Oliver Klee commented on patch set 2 07/26/23, 07:28

    Reply

    (marking as not resolved)
  7. Jochen Roth commented on patch set 2 CR -1 07/26/23, 09:22

    Will have a closer look to circumvent the symfony/process dependency.
  8. Stefan Bürk commented on patch set 2 CR -1 07/26/23, 13:40

    GraphicsMagickPreset.php:70

    This whole method is about to find the binary, doing a test command call. I guess we should add kind of checks to it: * `file_exists()` * `is_executable()` before making the thest call with exec and continue the loop early. And avoid the 3rd party dependencie for now.

    ImageMagick6Preset.php:70

    This whole method is about to find the binary, doing a test command call. I guess we should add kind of checks to it: * `file_exists()` * `is_executable()` before making the thest call with exec and continue the loop early. And avoid the 3rd party dependencie for now.
  9. Jochen Roth uploaded patch set 3 CR -1 V +1 07/26/23, 19:22

  10. Jochen Roth uploaded patch set 4 07/26/23, 19:24

  11. Jochen Roth uploaded patch set 5 07/26/23, 19:25

  12. core-ci voted on patch set 3 V +1 07/26/23, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44591

  13. core-ci voted on patch set 4 V -1 07/26/23, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44592

  14. core-ci voted on patch set 5 V +1 07/26/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44593

  15. Oli Bartsch voted on patch set 5 CR +1 07/27/23, 13:51

  16. Oliver Klee commented on patch set 5 CR +1 07/27/23, 13:52

    GraphicsMagickPreset.php:70 Reply

    Done

    ImageMagick6Preset.php:70 Reply

    Done
  17. Oliver Klee commented on patch set 5 07/27/23, 13:52

    Reply

    Done
  18. Torben Hansen commented on patch set 5 V +1 CR +1 07/27/23, 16:59

    Thanks!
  19. Stefan Bürk voted on patch set 5 V +2 CR +2 07/27/23, 19:22

  20. Stefan Bürk merged patch set 6 07/27/23, 19:32