Review main Abandoned

80186[WIP][TASK] Provide extbase request combat in non-extbase view context

Stefan Bürk CR 0 V 0 Normal +153 −12 updated 08/22/23, 12:40

Commit message

... @todo add background info here ....

This change introduces a internal request escalator
bound to a feature toggle to provide a compat layer
to use extbase related ViewHelper in non-extbase
based fluid view context.

The toggle is disabled for new instances, but
will be enabled for existing instances to provide
the compat during upgrade.

Note: This is really the big-hammer workaround to
      get old behaviour working along with reverting
      the performance benefit gained in non-extbase
      context. At least, it does not for every use
      of StandaloneView like before and only in cases
      related ViewHelpers are used.

Note: Only core implementation benefits from this.
      Custom ViewHelper implementation build upon
      the Extbase Request won't work out-of-the
      box with it.

@todo:
------
* extend tests
* add a important rest file to describe the feature
  toggle and clearly state the impact of allowing
  the escalation
* commit message

@questions:
-----------
* Should we add deprecation for the mitigated
  situations and remove the escalation for 13.0
  as breaking than ?

Alternative approache(s):
-------------------------
* https://review.typo3.org/c/Packages/TYPO3.CMS/+/80037

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 35

  1. Stefan Bürk uploaded patch set 1 07/27/23, 11:05

  2. core-ci voted on patch set 1 V -1 07/27/23, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44610

  3. Stefan Bürk uploaded patch set 2 V -1 07/27/23, 11:16

  4. core-ci voted on patch set 2 V +1 07/27/23, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44614

  5. Stefan Bürk abandoned the change 08/22/23, 12:40

    Don't like this solution. Will be handled in another way.