Review main Merged

80197[FEATURE] Migrate icon sizes to enum

Andreas Kienast CR +2 V +2 Expert +902 −652 updated 08/02/23, 10:08

Commit message

The icon size constants defined in `\TYPO3\CMS\Core\Imaging\Icon` are
moved into a new `TYPO3\CMS\Core\Imaging\IconSize` enum. All method
accepting the old string constants are adapted to accept the enum class
as well, while triggering a deprecation when a string is passed for
compatibility reasons.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 149

Show 129 more files

Review log 1422

  1. Andreas Kienast uploaded patch set 1 07/28/23, 07:18

  2. Andreas Kienast uploaded patch set 2 07/28/23, 07:20

  3. core-ci voted on patch set 1 V -1 07/28/23, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44645

  4. core-ci voted on patch set 2 V -1 07/28/23, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44647

  5. Andreas Kienast uploaded patch set 3 V -1 07/28/23, 11:45

  6. core-ci voted on patch set 3 V -1 07/28/23, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44668

  7. Andreas Kienast uploaded patch set 4 V -1 07/28/23, 12:28

  8. core-ci voted on patch set 4 V -1 07/28/23, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44671

  9. Andreas Kienast uploaded patch set 5 V -1 07/28/23, 12:39

  10. core-ci voted on patch set 5 V +1 07/28/23, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44672

  11. Benjamin Franzke uploaded patch set 6 V +1 07/28/23, 17:26

  12. Benjamin Franzke commented on patch set 6 07/28/23, 17:28

    Note for reviewers: You can shrink the diff (still consists some namespace changes, but is easier to grasp) by reverting some changes locally: git grep -l "IconSize::[A-Z]" | xargs sed -i 's/IconSize::\([A-Z]\)/Icon::SIZE_\1/g' && git diff HEAD^ variant for apple users: git grep -l "IconSize::[A-Z]" | xargs sed -i '' -e 's/IconSize::\([A-Z]\)/Icon::SIZE_\1/g' && git diff HEAD^
  13. core-ci voted on patch set 6 V -1 07/28/23, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44683

  14. Benjamin Franzke uploaded patch set 7 CR +1 V +1 07/28/23, 18:50

  15. core-ci voted on patch set 7 V +1 07/28/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44693

  16. Chris Müller commented on patch set 7 08/01/23, 17:13

    IconViewHelper.php:72

    "medium" is missing in the description. Additionally, "overlay" is marked as internal, so shouldn't mentioned here as it is not public API.
  17. Anja Leichsenring uploaded patch set 8 CR +1 V +1 08/02/23, 08:03

  18. Anja Leichsenring commented on patch set 8 V +1 CR +1 08/02/23, 08:05

    IconViewHelper.php:72 Reply

    Done
  19. core-ci voted on patch set 8 V +1 08/02/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44867

  20. Stefan Bürk voted on patch set 8 V +1 CR +1 08/02/23, 09:42

  21. Andreas Kienast voted on patch set 8 V +2 CR +2 08/02/23, 10:08

  22. Andreas Kienast merged patch set 9 08/02/23, 10:08