80197[FEATURE] Migrate icon sizes to enum
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 149
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+2 −2
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+6 −6
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+4 −4
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+4 −4
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+6 −6
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FileStorage/TreeController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+3 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+11 −11
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+5 −5
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+10 −10
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+5 −5
- typo3/sysext/backend/Classes/Controller/RecordListController.php+9 −9
Show 129 more files
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+4 −4
- typo3/sysext/backend/Classes/ElementBrowser/DatabaseBrowser.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+14 −14
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+4 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+4 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+15 −15
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+7 −7
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php+6 −6
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+7 −7
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+11 −11
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+7 −7
- typo3/sysext/backend/Classes/Form/Element/UuidElement.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php+3 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageThumbnails.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+2 −2
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php+2 −2
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+2 −2
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+2 −2
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+3 −3
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+3 −3
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+2 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+48 −48
- typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php+2 −2
- typo3/sysext/backend/Classes/Search/EventListener/AddLiveSearchResultActionsListener.php+2 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+3 −3
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+4 −4
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+7 −7
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php+3 −3
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php+3 −3
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php+3 −3
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+5 −5
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+4 −4
- typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php+3 −3
- typo3/sysext/backend/Classes/Tree/View/ContentMovingPagePositionMap.php+3 −3
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+7 −7
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −2
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+3 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+2 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+9 −9
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+5 −5
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+2 −2
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+2 −2
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+3 −3
- typo3/sysext/core/Classes/Controller/IconController.php+2 −1
- typo3/sysext/core/Classes/Imaging/Event/ModifyIconForResourcePropertiesEvent.php+12 −2
- typo3/sysext/core/Classes/Imaging/Dimension.php+8 −37
- typo3/sysext/core/Classes/Imaging/Icon.php+14 −5
- typo3/sysext/core/Classes/Imaging/IconFactory.php+38 −16
- typo3/sysext/core/Classes/Imaging/IconSize.phpnew+62 −0
- typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php+2 −2
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+2 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+2 −2
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+2 −2
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php2+3 −3
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101475-IconSizeStringConstants.rstnew+64 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101475-IconSizeEnum.rstnew+24 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+8 −8
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.php+2 −1
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+4 −3
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Imaging/DimensionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+16 −15
- typo3/sysext/core/Tests/UnitDeprecated/Imaging/IconTest.php+46 −2
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+2 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+4 −4
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/CreateFileController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+3 −3
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+7 −7
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+4 −3
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+2 −2
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+24 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+3 −3
- typo3/sysext/form/Classes/Controller/FormEditorController.php+7 −7
- typo3/sysext/form/Classes/Controller/FormManagerController.php+4 −4
- typo3/sysext/impexp/Classes/Controller/ExportController.php+4 −4
- typo3/sysext/impexp/Classes/Controller/ImportController.php+2 −2
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+3 −3
- typo3/sysext/impexp/Classes/ImportExport.php+7 −7
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+2 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+2 −2
- typo3/sysext/info/Classes/Controller/PageInformationController.php+6 −6
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+12 −12
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassConstantMatcher.php+25 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+2 −2
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+22 −22
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+2 −2
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+8 −8
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+4 −4
- typo3/sysext/sys_note/Classes/Provider/ButtonBarProvider.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+2 −2
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+3 −3
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+9 −9
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+4 −4
Review log 1422
-
Andreas Kienast uploaded patch set 1 07/28/23, 07:18
-
Andreas Kienast uploaded patch set 2 07/28/23, 07:20
-
core-ci voted on patch set 1 V -1 07/28/23, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44645
-
core-ci voted on patch set 2 V -1 07/28/23, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44647
-
Andreas Kienast uploaded patch set 3
V -107/28/23, 11:45 -
core-ci voted on patch set 3 V -1 07/28/23, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44668
-
Andreas Kienast uploaded patch set 4
V -107/28/23, 12:28 -
core-ci voted on patch set 4 V -1 07/28/23, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44671
-
Andreas Kienast uploaded patch set 5
V -107/28/23, 12:39 -
core-ci voted on patch set 5 V +1 07/28/23, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44672
-
Benjamin Franzke uploaded patch set 6
V +107/28/23, 17:26 -
Benjamin Franzke commented on patch set 6 07/28/23, 17:28
Note for reviewers: You can shrink the diff (still consists some namespace changes, but is easier to grasp) by reverting some changes locally: git grep -l "IconSize::[A-Z]" | xargs sed -i 's/IconSize::\([A-Z]\)/Icon::SIZE_\1/g' && git diff HEAD^ variant for apple users: git grep -l "IconSize::[A-Z]" | xargs sed -i '' -e 's/IconSize::\([A-Z]\)/Icon::SIZE_\1/g' && git diff HEAD^ -
core-ci voted on patch set 6 V -1 07/28/23, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44683
-
Benjamin Franzke uploaded patch set 7
CR +1V +107/28/23, 18:50 -
core-ci voted on patch set 7 V +1 07/28/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44693
-
Chris Müller commented on patch set 7 08/01/23, 17:13
IconViewHelper.php:72"medium" is missing in the description. Additionally, "overlay" is marked as internal, so shouldn't mentioned here as it is not public API. -
Anja Leichsenring uploaded patch set 8
CR +1V +108/02/23, 08:03 -
Anja Leichsenring commented on patch set 8 V +1 CR +1 08/02/23, 08:05
IconViewHelper.php:72ReplyDone -
core-ci voted on patch set 8 V +1 08/02/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44867
-
Stefan Bürk voted on patch set 8 V +1 CR +1 08/02/23, 09:42
-
Andreas Kienast voted on patch set 8 V +2 CR +2 08/02/23, 10:08
-
Andreas Kienast merged patch set 9 08/02/23, 10:08