Review main Merged

80204[BUGFIX] Extend CSP directives and sources

Oliver Hader CR +2 V +2 Normal +58 −17 updated 07/28/23, 20:18

Commit message

The CSP directives 'report-to', 'require-trusted-types-for' and
'trusted-types' have been added. Albeit there aren't any typed value
counterparts yet, they can be wrapped in a RawValue object, e.g.

new Mutation(
    MutationMode::Set,
    Directive::RequireTrustedTypesFor,
    new RawValue("'script'")
),

The stand-alone directives 'sandbox', 'trusted-types' and
'upgrade-insecure-request' now can be used without any values.
The cases for 'unsafe-hashes' and 'strict-dynamic' were accidentally
added as directives instead of source keywords and have been removed.

The source schemes 'filesystem:' and 'mediastream' have been added.

Besides that, the frontend CSP configuration now limits using the
`<base>` element to same-origin URIs. The backend CSP configuration
is now even stricter since using `<base>`, `<embed>` and `<object>`
elements is blocked.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1417

  1. Oliver Hader uploaded patch set 1 07/28/23, 17:51

  2. core-ci voted on patch set 1 V +1 07/28/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44686

  3. Oliver Hader uploaded patch set 2 V +1 07/28/23, 18:16

  4. core-ci voted on patch set 2 V +1 07/28/23, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44688

  5. Benjamin Franzke voted on patch set 2 CR +1 07/28/23, 18:47

  6. Benjamin Franzke voted on patch set 2 V +1 07/28/23, 19:06

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 07/28/23, 19:41

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 19:41

  9. Oliver Hader uploaded patch set 3 CR +1 V +1 07/28/23, 20:05

  10. Benjamin Franzke voted on patch set 3 V +1 CR +1 07/28/23, 20:06

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 07/28/23, 20:06

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 07/28/23, 20:06

  13. Oliver Hader commented on patch set 3 07/28/23, 20:11

    Thx folks 😊
  14. core-ci voted on patch set 3 V +1 07/28/23, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44703

  15. Christian Kuhn commented on patch set 3 07/28/23, 20:14

    yw 😊
  16. Oliver Hader voted on patch set 3 V +2 CR +2 07/28/23, 20:18

  17. Oliver Hader merged patch set 4 07/28/23, 20:18