Review main Merged

80209[DOCS] Fix problems in changelog for adding type declarations for ResourceInterface

Chris Müller CR +2 V +2 Normal +43 −38 updated 07/29/23, 10:00

Commit message

First, the code block must be introduced with "code-block:: php". Then, the FQCN must either have double backslashes or enclosed in ":php:" to be displayed correctly. Additionally, for the first mentioning of the ResourceInterface the FQCN is used.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Chris Müller uploaded patch set 1 07/29/23, 06:50

  2. Chris Müller updated the commit message in patch set 2 07/29/23, 06:54

  3. core-ci voted on patch set 1 V +1 07/29/23, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44709

  4. core-ci voted on patch set 2 V +1 07/29/23, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44710

  5. Oliver Klee commented on patch set 2 V +1 CR +1 07/29/23, 08:57

    Thanks for taking care of this! <3
  6. Stefan Bürk voted on patch set 2 V +2 CR +2 07/29/23, 10:00

  7. Stefan Bürk merged patch set 3 07/29/23, 10:00