Review 12.4 Merged

80215[BUGFIX] Properly evaluate selected class in BrowseLinksController

Christian Kuhn CR +2 V +2 Easy +17 −5 updated 07/28/23, 19:32

Commit message

Generally, adding a class to a link in CKeditor is done
via the corresponding link browser (BrowseLinksController),
which renders a select field with a list of allowed classes
(as configured). However, CKeditor  also automatically applies
a so called "highlighting class" to a link. Furthermore
it's always possible to manually set additional classes
via the "Source" view mode. To be able to properly resolve
an actually selected (allowed) class for the select field,
the current link class value is now cleanup up before
markup generation takes place in the BrowseLinksController.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 07/28/23, 19:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/28/23, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44696

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/28/23, 19:32

  4. Christian Kuhn merged patch set 2 07/28/23, 19:32