Review main Merged

80235[TASK] Use ConsumableNonce instead of blunt Nonce in CSP context

Oliver Hader CR +2 V +2 Normal +124 −98 updated 10/26/23, 16:09

Commit message

To identify whether a nonce values was actually used (consumed),
`ConsumableNonce` instances are used, instead of `Nonce` objects.
The new `ConsumableNonce` inherits from `ConsumableString`.

As a result, the `<f:security.nonce>` view helper would increase
the consumption counter. This is important for additional cache
handling in the frontend rendering context.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2024

  1. Oliver Hader uploaded patch set 1 07/29/23, 09:26

  2. Oliver Hader marked it work in progress 07/29/23, 09:26

  3. Oliver Hader uploaded patch set 2 07/29/23, 09:36

  4. core-ci voted on patch set 2 V +1 07/29/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44726

  5. Oliver Hader uploaded patch set 3 V +1 08/25/23, 07:05

  6. core-ci voted on patch set 3 V +1 08/25/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45821

  7. Oliver Hader commented on patch set 3 08/25/23, 07:20

    This change is ready for review.
  8. Oliver Hader rebased onto patch set 4 V +1 10/21/23, 17:15

  9. core-ci voted on patch set 4 V +1 10/21/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48010

  10. Benjamin Franzke voted on patch set 4 V +1 CR +1 10/23/23, 06:26

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 10/26/23, 12:40

  12. Oliver Hader voted on patch set 4 CR +2 10/26/23, 14:47

  13. Oliver Hader voted on patch set 4 CR -1 10/26/23, 15:47

  14. Oliver Hader uploaded patch set 5 CR +1 V +1 10/26/23, 15:53

  15. Oliver Hader uploaded patch set 6 10/26/23, 15:55

  16. Oliver Hader commented on patch set 6 10/26/23, 15:57

    Since the commit 99f86484aaf7f92fa9dc3615ae06ee282c5415b3 got merged in between, there were now new usages of `Nonce`...
  17. Oliver Hader commented on patch set 6 10/26/23, 15:59

  18. core-ci voted on patch set 6 V +1 10/26/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48247

  19. Oliver Hader voted on patch set 6 CR +1 10/26/23, 16:03

  20. Oliver Hader voted on patch set 6 CR 0 10/26/23, 16:03

  21. Oliver Hader commented on patch set 6 10/26/23, 16:07

    Thx for the previous reviews! I'm about to merge this change now...
  22. Oliver Hader voted on patch set 6 CR +2 10/26/23, 16:08

  23. Oliver Hader voted on patch set 6 V +2 10/26/23, 16:08

  24. Oliver Hader merged patch set 7 10/26/23, 16:09