80235[TASK] Use ConsumableNonce instead of blunt Nonce in CSP context
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+1 −1
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php+4 −3
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+5 −4
- typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php+1 −2
- typo3/sysext/core/Classes/Core/RequestId.php+3 −3
- typo3/sysext/core/Classes/Domain/ConsumableString.php+1 −1
- typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php+2 −2
- typo3/sysext/core/Classes/Page/AssetRenderer.php+6 −6
- typo3/sysext/core/Classes/Page/ImportMap.php+2 −2
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+3 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php+5 −5
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ConsumableNonce.phpnew+41 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ModelService.php+4 −8
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Policy.php+2 −3
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/SourceKeyword.php+1 −5
- typo3/sysext/core/Classes/Utility/DebugUtility.php+0 −6
- typo3/sysext/core/Tests/Functional/Security/ContentSecurityPolicy/PolicyTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+5 −6
- typo3/sysext/core/Tests/Unit/Page/ImportMapTest.php+10 −10
Show 9 more files
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+2 −2
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/NonceViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/Html/HtmlWorker.php+4 −3
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+3 −3
- typo3/sysext/frontend/Classes/Middleware/ContentSecurityPolicyHeaders.php+1 −2
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −3
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −3
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ContentSecurityPolicyMutationsProvider.php+2 −2
Review log 2024
-
Oliver Hader uploaded patch set 1 07/29/23, 09:26
-
Oliver Hader marked it work in progress 07/29/23, 09:26
-
Oliver Hader uploaded patch set 2 07/29/23, 09:36
-
core-ci voted on patch set 2 V +1 07/29/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44726
-
Oliver Hader uploaded patch set 3
V +108/25/23, 07:05 -
core-ci voted on patch set 3 V +1 08/25/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45821
-
Oliver Hader commented on patch set 3 08/25/23, 07:20
This change is ready for review. -
Oliver Hader rebased onto patch set 4
V +110/21/23, 17:15 -
core-ci voted on patch set 4 V +1 10/21/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48010
-
Benjamin Franzke voted on patch set 4 V +1 CR +1 10/23/23, 06:26
-
Andreas Kienast voted on patch set 4 V +1 CR +1 10/26/23, 12:40
-
Oliver Hader voted on patch set 4 CR +2 10/26/23, 14:47
-
Oliver Hader voted on patch set 4 CR -1 10/26/23, 15:47
-
Oliver Hader uploaded patch set 5
CR +1V +110/26/23, 15:53 -
Oliver Hader uploaded patch set 6 10/26/23, 15:55
-
Oliver Hader commented on patch set 6 10/26/23, 15:57
Since the commit 99f86484aaf7f92fa9dc3615ae06ee282c5415b3 got merged in between, there were now new usages of `Nonce`... -
Oliver Hader commented on patch set 6 10/26/23, 15:59
Reply
... referring to https://review.typo3.org/c/Packages/TYPO3.CMS/+/81180 -
core-ci voted on patch set 6 V +1 10/26/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48247
-
Oliver Hader voted on patch set 6 CR +1 10/26/23, 16:03
-
Oliver Hader voted on patch set 6 CR 0 10/26/23, 16:03
-
Oliver Hader commented on patch set 6 10/26/23, 16:07
Thx for the previous reviews! I'm about to merge this change now... -
Oliver Hader voted on patch set 6 CR +2 10/26/23, 16:08
-
Oliver Hader voted on patch set 6 V +2 10/26/23, 16:08
-
Oliver Hader merged patch set 7 10/26/23, 16:09