Review main Merged

80236[TASK] Apply more type declarations to ResourceStorage

Alexander Schnitzler CR +2 V +2 Normal +21 −49 updated 01/14/25, 20:37

Commit message

FAL/Resource handling is quite messy when looking at
type hints and return values. Changing something in
this area quickly leads to a can of worms. The patch
applies some types to the central ResourceStorage
class that are safe to set.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1219

  1. Alexander Schnitzler uploaded patch set 1 07/29/23, 09:52

  2. core-ci voted on patch set 1 V -1 07/29/23, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44727

  3. Christian Kuhn uploaded patch set 2 V -1 01/14/25, 19:15

  4. Christian Kuhn updated the commit message in patch set 3 01/14/25, 19:16

  5. core-ci voted on patch set 2 V -1 01/14/25, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72478

  6. core-ci voted on patch set 3 V -1 01/14/25, 19:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72479

  7. Christian Kuhn uploaded patch set 4 V -1 01/14/25, 19:30

  8. core-ci voted on patch set 4 V -1 01/14/25, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72480

  9. Christian Kuhn uploaded patch set 5 V -1 01/14/25, 19:39

  10. Christian Kuhn commented on patch set 5 01/14/25, 19:41

    This change is ready for review.
    hey. i stripped this patch down to far less changes to make it save and have less impact. FAL is type-wise very messy and we should start somewhere. this change should be good within ResourceStorage without being breaking.
  11. Oliver Klee updated the commit message in patch set 6 01/14/25, 19:44

  12. core-ci voted on patch set 5 V +1 01/14/25, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72481

  13. Oliver Klee commented on patch set 7 01/14/25, 19:49

    Published edit on patch set 6.
  14. core-ci voted on patch set 6 V +1 01/14/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72482

  15. Oliver Klee voted on patch set 7 CR +1 V +1 01/14/25, 19:52

  16. core-ci voted on patch set 7 V +1 01/14/25, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72483

  17. Stefan Bürk voted on patch set 7 CR +1 V +1 01/14/25, 20:02

  18. Christian Kuhn voted on patch set 7 CR +2 V +2 01/14/25, 20:37

  19. Christian Kuhn merged patch set 8 01/14/25, 20:37