Review main Merged

80238[TASK] Remove superfluous check in extbase HashService

Torben Hansen CR +2 V +2 Easy +2 −6 updated 08/02/23, 15:33

Commit message

The `generateHmac()` function in extbase `HashService` checks
for the existence of the TYPO3 encryption key and throws an exception
if no encryption key is set. This check is however superfluous, since
`TYPO3\CMS\Core\Core\Bootstrap::checkEncryptionKey()` already does
the same.

The check in extbase `HashService` can therefore safely be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 07/29/23, 11:13

  2. core-ci voted on patch set 1 V +1 07/29/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44734

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/02/23, 15:28

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/02/23, 15:33

  5. Christian Kuhn merged patch set 2 08/02/23, 15:33