Review main Merged

80240[BUGFIX] Avoid skipping ext_typoscript_* files in TS parser

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/30/23, 13:08

Commit message

A stupid return vs. continue issue breaks a loop
in SysTemplateTreeBuilder early, which leads to
`ext_typoscript_[setup|constants].typoscript` not
being considered when they have been partially
cached already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 07/30/23, 08:38

  2. core-ci voted on patch set 1 V +1 07/30/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44745

  3. Oliver Klee updated the commit message in patch set 2 V +1 07/30/23, 10:29

  4. Oliver Klee commented on patch set 2 07/30/23, 10:30

    Can we cover this with a regression test?
  5. core-ci voted on patch set 2 V +1 07/30/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44747

  6. Christian Kuhn commented on patch set 2 07/30/23, 11:58

    Reply

    too much effort for this obvious change - would need cached/not-cached FE setup stuff, that's quite some work. Let's bring this in as such.
  7. Stefan Bürk commented on patch set 2 V +1 CR +1 07/30/23, 11:59

    Reply

    Ack.
  8. Oliver Klee voted on patch set 2 CR +1 07/30/23, 12:38

  9. Jasmina Ließmann voted on patch set 2 V +1 CR +1 07/30/23, 12:53

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 07/30/23, 13:08

  11. Christian Kuhn merged patch set 3 07/30/23, 13:08