Review main Merged Breaking

80247[!!!][TASK] Add native type declarations to GU array methods

Oliver Klee CR +2 V +2 Easy +15 −10 updated 08/24/23, 16:38

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1622

  1. Oliver Klee uploaded patch set 1 07/30/23, 14:48

  2. Oliver Klee commented on patch set 1 CR -1 07/30/23, 14:50

    This should wait until after the T3DD23 so it doesn't cause problems for people at the coding night.
  3. core-ci voted on patch set 1 V -1 07/30/23, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44756

  4. Oliver Klee rebased onto patch set 2 CR -1 V -1 08/07/23, 10:30

  5. Oliver Klee commented on patch set 2 CR -1 08/07/23, 10:30

    I'll need to fix the failures first.
  6. core-ci voted on patch set 2 V -1 08/07/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45182

  7. Oliver Klee rebased onto patch set 3 CR -1 V -1 08/08/23, 18:35

  8. core-ci voted on patch set 3 V +1 08/08/23, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45255

  9. Oliver Klee updated the commit message in patch set 4 V +1 08/08/23, 18:44

  10. core-ci voted on patch set 4 V +1 08/08/23, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45256

  11. Andreas Kienast commented on patch set 4 08/09/23, 05:56

    GeneralUtility.php:839

    I wonder if that method cannot be simplified (in another patch, of course) that uses `http_build_query()` instead of manual array assembling.
  12. Oliver Klee commented on patch set 4 08/09/23, 07:41

    GeneralUtility.php:839 Reply

    I like the idea! Thanks! I've created an issue so it doesn't get lost: https://forge.typo3.org/issues/101625
  13. Oliver Klee rebased onto patch set 5 V +1 08/14/23, 16:38

  14. core-ci voted on patch set 5 V +1 08/14/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45484

  15. Thomas Hohn voted on patch set 5 CR +1 08/14/23, 18:29

  16. Stefan Bürk commented on patch set 5 08/15/23, 13:44

    GeneralUtility.php:839 Reply

    Small note/hint: The current implementation ensures a rawurlencode on values in a recursive manner. This needs to be carefully checked if replaced with `http_build_query()`. Maybe it makes sense to add special tests for this, if not already contained. (Not checked).
  17. Oliver Klee rebased onto patch set 6 CR +1 V +1 08/24/23, 08:40

  18. core-ci voted on patch set 6 V +1 08/24/23, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45778

  19. Nikita Hovratov voted on patch set 6 V +1 CR +1 08/24/23, 08:55

  20. Oliver Hader voted on patch set 6 CR +1 08/24/23, 16:34

  21. Oliver Hader voted on patch set 6 V +2 CR +2 08/24/23, 16:37

  22. Oliver Hader merged patch set 7 08/24/23, 16:38