Review main Abandoned

80259[TASK] Re-add versioned lit sources

Benjamin Franzke CR 0 V 0 Normal +63 −20 updated 08/08/23, 09:11

Commit message

The lit folders have been suffixed by an explicit version
string in #96511. This got removed with #100245, because
required updates for configuration files have not been
applied automatically and the reason for the version
suffix was undocumented and thus unclear.

In preparation for future lit updates, the version
suffix is added back to avoid a mixture of cached and
uncached lit source variants.
Explanation: absolute urls are cache busted by the hash
in the import map, but relative import (inside lit) can
not use cache bust parameters by design. This is why we need
a version suffixed package folder in order to enforce browser
cache updates, whenever lit sources are updated.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 103

Show 83 more files

Review log 67

  1. Benjamin Franzke uploaded patch set 1 07/31/23, 07:22

  2. core-ci voted on patch set 1 V +1 07/31/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44776

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/31/23, 08:17

  4. Benjamin Franzke commented on patch set 1 CR -2 07/31/23, 10:02

    Blocking this myself for now. Another idea is: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80268 (I'm fine with both, but the alternative is easier to work with during updates, so we'll probably go with that route – already had a chat about these with benji)
  5. Benni Mack commented on patch set 1 V 0 CR 0 08/08/23, 08:54

    can be abandoned?
  6. Benjamin Franzke commented on patch set 1 08/08/23, 09:10

    Found another usecase, why this would be useful (but undocumented): I optimized the importmap to avoid recurive path traversal for folders that are versioned via @x.y.z, so importmap for lit was "small" in any case. Anyway will abandon for now.
  7. Benjamin Franzke abandoned the change 08/08/23, 09:11