Review main Merged

80269[BUGFIX] Avoid undefined array key in AbstractFormElement

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 07/31/23, 13:40

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Nikita Hovratov uploaded patch set 1 07/31/23, 09:56

  2. core-ci voted on patch set 1 V +1 07/31/23, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44792

  3. Oliver Klee commented on patch set 1 07/31/23, 11:12

    AFAICS, this also affects 12.4, but not 11.5.
  4. Nikita Hovratov commented on patch set 1 07/31/23, 11:35

    Reply

    How that? These methods don't exist there.
  5. Nikita Hovratov updated the commit message in patch set 2 V +1 07/31/23, 11:40

  6. core-ci voted on patch set 2 V +1 07/31/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44806

  7. Nikita Hovratov updated the commit message in patch set 3 V +1 07/31/23, 12:23

  8. Nikita Hovratov commented on patch set 3 07/31/23, 12:23

    Reply

    Oh, sorry. Didn't have debug mode enabled in my v12 branch.
  9. Oliver Klee voted on patch set 3 V +1 CR +1 07/31/23, 12:39

  10. core-ci voted on patch set 3 V +1 07/31/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44815

  11. Benni Mack voted on patch set 3 V +1 CR +1 07/31/23, 13:34

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 07/31/23, 13:39

  13. Christian Kuhn merged patch set 4 07/31/23, 13:40