80271[BUGFIX] Ensure inline fieldset items do not float
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1015
-
Nikita Hovratov uploaded patch set 1 07/31/23, 10:27
-
core-ci voted on patch set 1 V +1 07/31/23, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44796
-
Nikita Hovratov updated the commit message in patch set 2
V +107/31/23, 14:17 -
core-ci voted on patch set 2 V +1 07/31/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44823
-
Nikita Hovratov rebased onto patch set 3
V +108/09/23, 20:18 -
core-ci voted on patch set 3 V +1 08/09/23, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45295
-
Oliver Klee updated the commit message in patch set 4
V +108/09/23, 21:17 -
core-ci voted on patch set 4 V +1 08/09/23, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45302
-
Benjamin Franzke commented on patch set 4 CR -1 08/10/23, 10:41
Hm.. So as this is caused by #101279 – because legend created a floating context, I think it would be better to actually add sth like: .form-legend float: none To fix this for all components that are inline (by default or why ever) and worked previously. Will edit the patch later if you don't mind. -
Benjamin Franzke uploaded patch set 5
CR -1V +108/10/23, 11:30 -
core-ci voted on patch set 5 V +1 08/10/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45329
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 08/14/23, 17:23
-
Stefan Bürk voted on patch set 5 V +1 CR +1 08/15/23, 09:46
-
Nikita Hovratov voted on patch set 5 V +2 CR +2 08/15/23, 10:47
-
Nikita Hovratov merged patch set 6 08/15/23, 10:47