Review main Merged

80276[TASK] Streamline RequestBuilderTest

Oliver Klee CR +2 V +2 Normal +22 −37 updated 07/31/23, 13:36

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Oliver Klee uploaded patch set 1 07/31/23, 12:05

  2. Christian Kuhn commented on patch set 1 CR -1 07/31/23, 12:07

    RequestBuilderTest.php:254

    removing this makes phpstorm not understand the methods on $uploadedFile
  3. Christian Kuhn commented on patch set 1 07/31/23, 12:09

    RequestBuilderTest.php:328

    same. keep these.

    RequestBuilderTest.php:335

    same. keep these.
  4. core-ci voted on patch set 1 V +1 07/31/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44812

  5. Oliver Klee commented on patch set 1 07/31/23, 12:41

    RequestBuilderTest.php:254 Reply

    Ah, I mixed up some things. We don't need to have the `@var` annotation (because `assertInstanceOf` provides PHPStan with the type information, but still things should be in the right order, and the `assertInstanceOf` should be on the variable, not the array element. On it.
  6. Oliver Klee rebased onto patch set 2 CR -1 V +1 07/31/23, 12:43

  7. core-ci voted on patch set 2 V +1 07/31/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44817

  8. Christian Kuhn commented on patch set 2 V +2 CR +2 07/31/23, 13:36

    RequestBuilderTest.php:254 Reply

    Ack

    RequestBuilderTest.php:328 Reply

    Ack

    RequestBuilderTest.php:335 Reply

    Ack
  9. Christian Kuhn merged patch set 3 07/31/23, 13:36