80276[TASK] Streamline RequestBuilderTest
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 2
Files 1
Review log 79
-
Oliver Klee uploaded patch set 1 07/31/23, 12:05
-
Christian Kuhn commented on patch set 1 CR -1 07/31/23, 12:07
-
Christian Kuhn commented on patch set 1 07/31/23, 12:09
RequestBuilderTest.php:328same. keep these.RequestBuilderTest.php:335same. keep these. -
core-ci voted on patch set 1 V +1 07/31/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44812
-
Oliver Klee commented on patch set 1 07/31/23, 12:41
RequestBuilderTest.php:254ReplyAh, I mixed up some things. We don't need to have the `@var` annotation (because `assertInstanceOf` provides PHPStan with the type information, but still things should be in the right order, and the `assertInstanceOf` should be on the variable, not the array element. On it. -
Oliver Klee rebased onto patch set 2
CR -1V +107/31/23, 12:43 -
core-ci voted on patch set 2 V +1 07/31/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44817
-
Christian Kuhn commented on patch set 2 V +2 CR +2 07/31/23, 13:36
RequestBuilderTest.php:254ReplyAckRequestBuilderTest.php:328ReplyAckRequestBuilderTest.php:335ReplyAck -
Christian Kuhn merged patch set 3 07/31/23, 13:36
RequestBuilderTest.php:254