Review main Merged

80279[TASK] Refactor DefaultTcaSchema

Christian Kuhn CR +2 V +2 Normal +101 −80 updated 07/31/23, 18:18

Commit message

In preparation of upcoming features in this area,
the `@internal` class is refactored a bit:

* `getPrioritizedFieldNames()` is moved into
  `SchemaMigrator` - it is logically more bound
  to this class and can live there as protected
  method.

* Split `enrichSingleTableFields()` into two methods:
  One for fields created from TCA `ctrl`, one for
  fields created from `columns`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/31/23, 15:35

  2. core-ci voted on patch set 1 V +1 07/31/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44827

  3. Oliver Klee updated the commit message in patch set 2 V +1 07/31/23, 15:47

  4. core-ci voted on patch set 2 V +1 07/31/23, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44830

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/31/23, 17:12

  6. Oliver Klee voted on patch set 2 V +1 CR +1 07/31/23, 18:15

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/31/23, 18:18

  8. Christian Kuhn merged patch set 3 07/31/23, 18:18