Review 11.5 Merged

80280[BUGFIX] Stabilize AbstractDomainObject _isDirty check

Nikita Hovratov CR +2 V +2 Easy +13 −2 updated 09/07/23, 20:12

Commit message

Accessing static properties as non-static has always
triggered a notice in PHP. However, since PHP 8.0
accessing undefined properties (which always comes with
the former notice) is now a warning. This will be
caught by the error handler in debug mode.

To fix this, the more robust _getProperty method is
backported from #100120 and used in the _isDirty method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 07/31/23, 15:38

  2. Nikita Hovratov rebased onto patch set 2 07/31/23, 15:39

  3. core-ci voted on patch set 1 V +1 07/31/23, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44828

  4. core-ci voted on patch set 2 V +1 07/31/23, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44829

  5. Oliver Klee voted on patch set 2 V +1 CR +1 07/31/23, 15:56

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 09/07/23, 20:12

  7. Stefan Bürk merged patch set 3 09/07/23, 20:12