Review main Merged

80282[BUGFIX] Ensure string in htmlspecialchars()

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/31/23, 18:12

Commit message

When select fields with db relations allow pages
records, the DatabaseBrowser tries to render an
icon from the page row. uid of that row may be
an int, which needs to be cast to string to be
fed to htmlspecialchars().

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Nikita Hovratov +1

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 07/31/23, 17:43

  2. core-ci voted on patch set 1 V +1 07/31/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44832

  3. Oliver Klee voted on patch set 1 V +1 CR +1 07/31/23, 17:50

  4. Nikita Hovratov updated the commit message in patch set 2 CR +1 V +1 07/31/23, 18:04

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 07/31/23, 18:06

  6. Oliver Klee voted on patch set 2 V +1 CR +1 07/31/23, 18:11

  7. Georg Ringer voted on patch set 2 V +2 CR +2 07/31/23, 18:12

  8. Georg Ringer merged patch set 3 07/31/23, 18:12

  9. core-ci voted on patch set 2 V +1 07/31/23, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44834