80290[TASK] Use constructor property promotion for Mfa\Provider
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- Jörg Bösche +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- Christian Kuhn +1
- Jörg Bösche +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodes.php+1 −3
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodesProvider.php+4 −13
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/Totp.php+9 −21
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php+1 −4
Review log 912
-
Oliver Klee uploaded patch set 1 08/01/23, 08:37
-
core-ci voted on patch set 1 V +1 08/01/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44849
-
Oliver Klee commented on patch set 1 CR -1 08/01/23, 08:53
On it. -
Oliver Klee uploaded patch set 2
CR -1V +108/01/23, 08:56 -
core-ci voted on patch set 2 V +1 08/01/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44851
-
Oliver Klee rebased onto patch set 3
V +108/03/23, 06:18 -
core-ci voted on patch set 3 V +1 08/03/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44913
-
Jörg Bösche voted on patch set 3 V +1 CR +1 08/03/23, 19:21
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/05/23, 19:25
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/05/23, 19:25
-
Stefan Bürk voted on patch set 3 V +2 CR +2 08/05/23, 19:26
-
Stefan Bürk merged patch set 4 08/05/23, 19:26