Review main Merged

80293[TASK] Correct indentation of json files

Lina Wolf CR +2 V +2 Easy +22 −22 updated 08/02/23, 13:37

Commit message

They should conform to the settings in `.editorconfig`.
When your editor uses the `.editorconfig` file,
these files become very hard to edit.

I would backport this to make backports easier.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1520

  1. Lina Wolf uploaded patch set 1 08/02/23, 10:42

  2. Andreas Kienast commented on patch set 1 CR -1 08/02/23, 10:45

    The icons.json file comes from the `@typo3/icons` npm package, we shouldn't fiddle with that.
  3. core-ci voted on patch set 1 V -1 08/02/23, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44872

  4. Lina Wolf uploaded patch set 2 CR -1 V -1 08/02/23, 11:25

  5. Oliver Klee voted on patch set 2 V +1 CR +1 08/02/23, 11:30

  6. core-ci voted on patch set 2 V -1 08/02/23, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44877

  7. Oliver Klee voted on patch set 2 V 0 08/02/23, 11:36

  8. Lina Wolf uploaded patch set 3 CR +1 V -1 08/02/23, 11:38

  9. Oliver Klee voted on patch set 3 CR +1 08/02/23, 11:40

  10. Lina Wolf rebased onto patch set 4 CR +1 08/02/23, 11:42

  11. Oliver Klee updated the commit message in patch set 5 08/02/23, 11:42

  12. Oliver Klee voted on patch set 5 CR +1 08/02/23, 11:42

  13. core-ci voted on patch set 3 V +1 08/02/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44881

  14. core-ci voted on patch set 4 V +1 08/02/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44882

  15. core-ci voted on patch set 5 V +1 08/02/23, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44883

  16. Lina Wolf commented on patch set 5 08/02/23, 11:57

    Reply

    I just learned as much. Removed the changes to it
  17. Oliver Klee voted on patch set 5 V +1 08/02/23, 11:57

  18. Jasmina Ließmann voted on patch set 5 CR +1 08/02/23, 12:26

  19. Christian Kuhn voted on patch set 5 V +2 CR +2 08/02/23, 13:37

  20. Christian Kuhn merged patch set 6 08/02/23, 13:37